Update tag commands in gmpv8 and exclude tests from installation #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qha
force-pushed
the
update-tag-commands-in-gmpv8
branch
from
fa8465b
to
9924f92
Compare
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=========================================
+ Coverage 96.33% 96.4% +0.07%
=========================================
Files 10 10
Lines 2428 2479 +51
=========================================
+ Hits 2339 2390 +51
Misses 89 89
Continue to review full report at Codecov.
|
qha
force-pushed
the
update-tag-commands-in-gmpv8
branch
from
9924f92
to
979dedc
Compare
qha
force-pushed
the
update-tag-commands-in-gmpv8
branch
from
979dedc
to
f6c1a7a
Compare
qha
force-pushed
the
update-tag-commands-in-gmpv8
branch
from
f6c1a7a
to
9694136
Compare
qha
force-pushed
the
update-tag-commands-in-gmpv8
branch
from
9694136
to
d73b1aa
Compare
bjoernricks
approved these changes
Apr 23, 2019
|
I would apply 1829bdd if Gmpv8 is changed too. Regarding the tests, I am not sure if they should be excluded from the wheel completely but installing them as tests package seems bad to me. So I would go for it too. Feel free to create on PR for both changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement create_tag and modify_tag in gvm.protocols.gmpv8 with parameters and sent command structure according to the api documentation.
Exclude tests from installation.
The first commit concerning gvm.protocols.gmpv8:create_tag has actually been tested against a gvm, the rest are armchair exercises. I will be happy to create a new merge request with only tested code (though i don't anticipate a need for modify_tag in my projects) or to squash the commits if you prefer.
Checklist: